Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to megaparsec-7 #90

Closed
chshersh opened this issue Sep 7, 2018 · 2 comments · Fixed by #96
Closed

Migrate to megaparsec-7 #90

chshersh opened this issue Sep 7, 2018 · 2 comments · Fixed by #96
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ parser Everything related to `Text -> Toml`
Milestone
v1.0.0: Public re...

Comments

@chshersh
Copy link
Contributor

chshersh commented Sep 7, 2018

Performance of megaparsec was greatly improved in version 7. So it's a good idea to migrate to newer version.
@chshersh chshersh added the parser Everything related to `Text -> Toml` label Sep 7, 2018
@chshersh chshersh added this to the v1.0.0: Public release milestone Sep 7, 2018
@vrom911 vrom911 added good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 30, 2018
@vrom911 vrom911 mentioned this issue Sep 30, 2018
Closed
cocreature added a commit to cocreature/tomland that referenced this issue Oct 1, 2018
@cocreature
[kowainik#90] Migrate to megaparsec 7
8f3f545 
fixes kowainik#90, fixes kowainik#76
@cocreature cocreature mentioned this issue Oct 1, 2018
Merged
cocreature added a commit to cocreature/tomland that referenced this issue Oct 1, 2018
@cocreature
[kowainik#90] Migrate to megaparsec 7
20d1c74 
fixes kowainik#90, fixes kowainik#76
cocreature added a commit to cocreature/tomland that referenced this issue Oct 1, 2018
@cocreature
[kowainik#90] Migrate to megaparsec 7
47ea41a 
fixes kowainik#90, fixes kowainik#76
cocreature added a commit to cocreature/tomland that referenced this issue Oct 1, 2018
@cocreature
[kowainik#90] Migrate to megaparsec 7
73417cd 
fixes kowainik#90, fixes kowainik#76
chshersh pushed a commit that referenced this issue Oct 1, 2018
@cocreature @chshersh
[#90] Migrate to megaparsec 7 (#96)
5a18d9c 
fixes #90, fixes #76
@athas
Copy link

athas commented Oct 21, 2018

Could you also make a new release of tomland? Stackage is still blocked on upgrading to Megaparsec 7 because the newest released version of tomland (0.4.0) does not work with it.

@chshersh
Copy link
Contributor Author

@athas We're going to make release of tomland-0.5.0 at the end of the October, when the Hacktoberfest ends. There're still a lot of people actively working on this project, so it's a little bit inconvenient to create release now. I'm okay for tomland to not be on Stackage for a while. And I wonder, how many packages are using it? 🤔

Here I see only two packages:

life-sync is not on Hackage, and summoner already has open issue to migrate to newer tomland version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ parser Everything related to `Text -> Toml`
Projects
None yet
Milestone
v1.0.0: Public release
Development

Successfully merging a pull request may close this issue.

[#90] Migrate to megaparsec 7 cocreature/tomland
3 participants
@athas @chshersh @vrom911