Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type and default value to popup of auto-completion #54

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

koxudaxi
Copy link
Owner

Detail

The PR adds a type and a default value on popup of auto-completion

Related issues

#53

ScreenShots

ss2019-08-29 20 48 32

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.39%.
The diff coverage is 94.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     85.21%   85.61%   +0.39%     
  Complexity       60       60              
============================================
  Files             7        7              
  Lines           257      278      +21     
  Branches         86       89       +3     
============================================
+ Hits            219      238      +19     
  Misses            1        1              
- Partials         37       39       +2
Impacted Files Coverage Δ Complexity Δ
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 91.17% <ø> (-0.26%) 4 <0> (ø)
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 93.87% <100%> (ø) 12 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 60% <50%> (-6.67%) 0 <0> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 95.38% <96.22%> (+0.03%) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545f919...6ed08ba. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.39%.
The diff coverage is 94.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     85.21%   85.61%   +0.39%     
  Complexity       60       60              
============================================
  Files             7        7              
  Lines           257      278      +21     
  Branches         86       89       +3     
============================================
+ Hits            219      238      +19     
  Misses            1        1              
- Partials         37       39       +2
Impacted Files Coverage Δ Complexity Δ
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 91.17% <ø> (-0.26%) 4 <0> (ø)
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 93.87% <100%> (ø) 12 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 60% <50%> (-6.67%) 0 <0> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 95.38% <96.22%> (+0.03%) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545f919...6ed08ba. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.39%.
The diff coverage is 94.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     85.21%   85.61%   +0.39%     
  Complexity       60       60              
============================================
  Files             7        7              
  Lines           257      278      +21     
  Branches         86       89       +3     
============================================
+ Hits            219      238      +19     
  Misses            1        1              
- Partials         37       39       +2
Impacted Files Coverage Δ Complexity Δ
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 91.17% <ø> (-0.26%) 4 <0> (ø)
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 93.87% <100%> (ø) 12 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 60% <50%> (-6.67%) 0 <0> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 95.38% <96.22%> (+0.03%) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545f919...6ed08ba. Read the comment docs.

@koxudaxi koxudaxi merged commit 8808a0f into master Aug 29, 2019
@koxudaxi koxudaxi deleted the add_type_to_suggestion_of_auto_completion branch August 29, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant