Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat model validator as an instance method when mode='after' #779

Merged
merged 3 commits into from Aug 5, 2023

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Aug 5, 2023

Closes: #774

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.21% ⚠️

Comparison is base (77c7f48) 72.06% compared to head (dc3fd6e) 71.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   72.06%   71.85%   -0.21%     
==========================================
  Files          27       27              
  Lines        2044     2054      +10     
  Branches      625      630       +5     
==========================================
+ Hits         1473     1476       +3     
- Misses        273      275       +2     
- Partials      298      303       +5     
Files Changed Coverage Δ
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 77.25% <0.00%> (ø)
...xi/pydantic/PydanticTypedValidatorMethodHandler.kt 0.00% <0.00%> (ø)
src/com/koxudaxi/pydantic/Pydantic.kt 76.39% <47.05%> (-1.30%) ⬇️
.../com/koxudaxi/pydantic/PydanticIgnoreInspection.kt 87.50% <80.00%> (-12.50%) ⬇️
src/com/koxudaxi/pydantic/PydanticInspection.kt 84.77% <100.00%> (+0.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Qodana Community for Python

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@koxudaxi koxudaxi merged commit bd665a1 into main Aug 5, 2023
3 of 5 checks passed
@koxudaxi koxudaxi deleted the fix_model_validator_mode_after branch August 5, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@model_validator(mode="after") is not class methdod
1 participant