Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modshift buttons missing (Branch C) #585

Closed
ren2r opened this issue Sep 28, 2020 · 2 comments
Closed

Modshift buttons missing (Branch C) #585

ren2r opened this issue Sep 28, 2020 · 2 comments

Comments

@ren2r
Copy link
Contributor

ren2r commented Sep 28, 2020 •
edited
Loading

I was trying to set some modshift for certain buttons, and could not set the modshift to activate with the buttons "BACK", "STICKPRESS", "RPADPRESS" and "LPADPRESS", looking in the code I could notice that those variables is missing in the file "./src/conversions/string_constants.c" and by puting then there I could get the daemon to recognize these modshift.
I would submit a pull request, but as the python code has some Pad actions mapped with the words without "PRESS", I thought I could break something.
Would you kindly take a look at this?
kozec added a commit that referenced this issue Oct 11, 2020
@kozec
Unified LPADPRESS/RPADPRESS constants. Fixes #585
ba861cf
@kozec
Copy link
Owner

kozec commented Oct 11, 2020

Fixed in c branch.

@kozec
Copy link
Owner

kozec commented Oct 13, 2020

Fixed in latest pre-release

@kozec kozec closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kozec @ren2r