Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors and style reloaded #259

Closed
wants to merge 5 commits into from
Closed

colors and style reloaded #259

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2017

Made these changes for your consideration. Minimal barely transparent menus and keyboard so it looks nice over game and is still clearly visible. Better looking messages.

1
2
3

Used black and white colors so that text and highlight colors can be changed from green to blue, red etc. to represent different controllers if needed later.

There is a config option for opacity but it is not read from there. If you don't mind you do configuration part. There should be option to disable opacity if users are having performance issues.

@kozec
Copy link
Owner

kozec commented Sep 18, 2017

That looks pretty good, but I believe everything should have at least small border all around, otherwise if will blend too much on dark background.

But more importantly, are you saying you managed to get transparency working? That's great O.o
What window manager are you using?

@ghost
Copy link
Author

ghost commented Sep 18, 2017

I would prefer it without border, for me that is the idea behind transparency - blend into games. I don't think dark games are problem because menu and keyboard will still be clearly visible just not where they begin/end. + minimal design means getting rid of everything but essential information... but it's your choice just let me know if you still want it.

I'm on Ubuntu 16.04. Transparency is on entire window and minimal only 5%.

@ghost
Copy link
Author

ghost commented Sep 19, 2017

This also works.

1505777423-3384
This is main menu being set to 0.35 opacity while submenu is showing.

@kozec
Copy link
Owner

kozec commented Sep 19, 2017

Well, I can always leave border configurable, IRRC it shows differently on Ubuntu anyway.

That last picture looks good as well. I'll try to check out your branch, add config UI and merge everything to master if you are OK with that :)

@ghost
Copy link
Author

ghost commented Sep 19, 2017

Awesome, I'll start working on something else. :)

@kozec kozec mentioned this pull request Nov 5, 2017
7 tasks
kozec added a commit that referenced this pull request Nov 16, 2017
@kozec
Copy link
Owner

kozec commented Nov 16, 2017

It may looks like I forgot about this, but in fact, I just merged it into v0.4 branch, along with long needed GUI for selecting color scheme and style.

styles

I just wanna check, is it OK with you to call this style "Reloaded", or if it was meant just for PR title?

@ghost
Copy link
Author

ghost commented Nov 16, 2017

Nice! Yeah ok, sounds good.

@ghost ghost closed this Nov 17, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants