adding unit tests

clean/playbyplay_espn.py

@@ -23,11 +23,6 @@ class Clean:
     def __init__(self, filename, gamedata, dbobj):
         self.filename = filename
         self.gamedata = gamedata
-        self.away_team_id = self.gamedata['away_team_id']
-        self.home_team_id = self.gamedata['home_team_id']
-        self.game_name = self.gamedata['abbrev']
-        self.game_id = self.gamedata['id']
-        self.date_played = self.gamedata['date_played']
         self.db = dbobj
         self.find_player = find_player.FindPlayer(dbobj)
 
@@ -109,23 +104,13 @@ def guessUnknownQuarters(self, plays):
         return newdata
 
 
-    def _getConformedTimes(self):
-        return self.db.query_dict("SELECT * FROM dim_times")
-
-
     def replaceWithConformedTime(self, plays):
-        #conformed_times = self._getConformedTimes()
         cleaned = []
         for line in plays:
-        #for (period, idx, time_left, away_score, home_score, away_play, home_play) in plays:
-            #found = [(itm['period'], itm['deciseconds_left']) for itm in conformed_times if itm['period_name'] == period and itm['time_left'] == time_left][0]
-            #period = found[0]
-            #time_left = found[1]
             line['deciseconds_left'] = (int(line['time_left'].split(':')[0]) * 60 + int(line['time_left'].split(':')[1])) * 10
             del line['time_left']
 
             cleaned.append(line)
-            #cleaned.append((period, idx, new_time_left, away_score, home_score, away_play, home_play)) 
 
         return cleaned
 
@@ -154,7 +139,7 @@ def replaceBlankScores(self, data):
     def addGameId(self, data):
         new = []
         for i, line in enumerate(data):
-            line['game_id'] = self.game_id
+            line['game_id'] = self.gamedata['id']
             new.append(line) 
 
         return new
@@ -167,9 +152,9 @@ def identifyPlays(self, plays):
             # Define the team_id based on whether away or home table cell was filled in
             line['play_desc'] = self._resolvePlayDescription(line['away_play'], line['home_play'])
             if line['play_desc'] == line['home_play']:
-                line['team_id'] = self.home_team_id
+                line['team_id'] = self.gamedata['home_team_id']
             elif line['play_desc'] == line['away_play']:
-                line['team_id'] = self.away_team_id
+                line['team_id'] = self.gamedata['away_team_id']
 
             line['play_espn_id'], othervars = self._findPlay(line['play_desc'])
 
@@ -285,8 +270,8 @@ def _getPlayerIdsInGame(self):
 
 
     def _getTeams(self):
-        self.home_team = self.db.query_dict("SELECT * FROM team WHERE id = %s" % (self.home_team_id))[0]
-        self.away_team = self.db.query_dict("SELECT * FROM team WHERE id = %s" % (self.away_team_id))[0]
+        self.home_team = self.db.query_dict("SELECT * FROM team WHERE id = %s" % (self.gamedata['home_team_id']))[0]
+        self.away_team = self.db.query_dict("SELECT * FROM team WHERE id = %s" % (self.gamedata['away_team_id']))[0]
 
 
     def dumpIntoFile(self, data):

extract/playbyplay_espn.py

@@ -14,11 +14,8 @@ class Extract:
     def __init__(self, html, filename, gamedata):
         self.html = html
         self.gamedata = gamedata
-        self.game_name = self.gamedata['abbrev']
         self.filename = filename
 
-        self.home_team_city = self.gamedata['home_team_city']
-        self.away_team_city = self.gamedata['away_team_city']
 
 
     def extractAndDump(self):
@@ -146,10 +143,10 @@ def _getTimeouts(self, rows):
 
         cleaned_timeouts = []
         for (counter, time_left, action) in timeouts:
-            if self.home_team_city.lower() in action.lower():
+            if self.gamedata['home_team_city'].lower() in action.lower():
                 cleaned_timeouts.append((counter, time_left,'','','',action))
 
-            elif self.away_team_city.lower() in action.lower():
+            elif self.gamedata['away_team_city'].lower() in action.lower():
                 cleaned_timeouts.append((counter, time_left,'','',action,''))
             else:
                 cleaned_timeouts.append((counter, time_left,'','',action,''))

extract/shotchart_cbssports.py

@@ -17,9 +17,6 @@ class ShotExtract:
     def __init__(self, html, filename, gamedata):
         self.html = html
         self.gamedata = gamedata
-        self.game_name = self.gamedata['abbrev']
-        self.away_team = self.gamedata['away_team_id']
-        self.home_team = self.gamedata['home_team_id']
         self.filename = filename
 
 
@@ -38,7 +35,7 @@ def getHomePlayers(self):
 
         match = pattern.search(self.html)
         if match:
-            matched = [[self.home_team, player.split(':')[0]] + player.split(':')[1].split(',') for player in match.group('info').split('|')] 
+            matched = [[self.gamedata['home_team_id'], player.split(':')[0]] + player.split(':')[1].split(',') for player in match.group('info').split('|')] 
             return matched
 
         return []
@@ -49,7 +46,7 @@ def getAwayPlayers(self):
 
         match = pattern.search(self.html)
         if match:
-            matched = [[self.away_team, player.split(':')[0]] + player.split(':')[1].split(',') for player in match.group('info').split('|')] 
+            matched = [[self.gamedata['away_team_id'], player.split(':')[0]] + player.split(':')[1].split(',') for player in match.group('info').split('|')] 
             return matched
 
         return []