Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing typegoose cache after destroying the module #40

Merged
merged 9 commits into from
Nov 24, 2019

Conversation

Goodluckhf
Copy link
Contributor

@Goodluckhf Goodluckhf commented Nov 7, 2019

This fix #41

src/typegoose-core.module.ts Outdated Show resolved Hide resolved
@Goodluckhf
Copy link
Contributor Author

@hasezoey
So will we update typegoose version here and add .deleteModel?

@hasezoey
Copy link
Contributor

hasezoey commented Nov 8, 2019

it will be shipped in (typegoose) 6.1.1 (not released yet)

@hasezoey
Copy link
Contributor

hasezoey commented Nov 8, 2019

as a note: 6.1.1 is now released

@Goodluckhf
Copy link
Contributor Author

@hasezoey
I've updated typegoose and mongoose and add .deleteModel()

@hasezoey
Copy link
Contributor

hasezoey commented Nov 8, 2019

typescript version should probably be updated, reason:
in versions <3.5 the "Omit" type does not exists, and the current typescript version is "3.4.x"

(see current failing travis test)

@Goodluckhf
Copy link
Contributor Author

@hasezoey I've tried to update typescript to latest but i got this error:
image

So I just increase 1 minor version

@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.8%) to 93.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/typegoose-core.module.ts 3 6 50.0%
Totals Coverage Status
Change from base Build 74: -4.8%
Covered Lines: 70
Relevant Lines: 74

💛 - Coveralls

@hasezoey
Copy link
Contributor

hasezoey commented Nov 8, 2019

i think this needs to be investigated & fixed, but i think out-of-scope for this pr

@hasezoey
Copy link
Contributor

hasezoey commented Nov 9, 2019

@hasezoey I've tried to update typescript to latest but i got this error:

@Goodluckhf i now know where the error was (the gulp build process), fixed it, will make a new pr for updating dependencies

This was referenced Nov 9, 2019
@kpfromer
Copy link
Owner

Looks good.

@kpfromer kpfromer merged commit 3993cf1 into kpfromer:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Once destroy module models will not use correct connection
4 participants