Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing typegoose cache after destroying the module #40

Merged
merged 9 commits into from
Nov 24, 2019
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
"url": "https://github.com/kpfromer/nestjs-typegoose"
},
"peerDependencies": {
"@typegoose/typegoose": "^6.0.0",
"@typegoose/typegoose": "^6.1.1",
"@nestjs/common": "^6.3.1",
"@nestjs/core": "^6.3.1",
"mongoose": "^5.5.13"
"mongoose": "^5.7.9"
},
"dependencies": {
"is-class": "^0.0.7",
"reflect-metadata": "^0.1.13"
},
"devDependencies": {
"@typegoose/typegoose": "^6.0.0",
"@typegoose/typegoose": "^6.1.1",
"@nestjs/common": "^6.7.2",
"@nestjs/core": "^6.7.2",
"@nestjs/platform-express": "^6.7.2",
Expand All @@ -43,13 +43,13 @@
"gulp-typescript": "^5.0.1",
"jest": "^24.9.0",
"mockgoose": "latest",
"mongoose": "^5.7.1",
"mongoose": "^5.7.9",
"rimraf": "^2.7.1",
"rxjs": "^6.5.3",
"supertest": "latest",
"ts-jest": "^24.1.0",
"tslint": "^5.20.0",
"typescript": "3.4.3"
"typescript": "3.5.3"
},
"jest": {
"moduleFileExtensions": [
Expand Down
12 changes: 10 additions & 2 deletions src/typegoose-core.module.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import * as mongoose from 'mongoose';
import { models } from '@typegoose/typegoose/lib/internal/data';
import { DynamicModule, Global, Module, Provider, OnModuleDestroy, Inject } from '@nestjs/common';
import { ModuleRef } from '@nestjs/core';
import { TypegooseOptionsFactory, TypegooseModuleOptions, TypegooseModuleAsyncOptions, TypegooseConnectionOptions } from './typegoose-options.interface';
import { TYPEGOOSE_CONNECTION_NAME, TYPEGOOSE_MODULE_OPTIONS } from './typegoose.constants';
import { getConnectionToken } from './typegoose.utils';
import { deleteModel } from '@typegoose/typegoose';

@Global()
@Module({})
Expand All @@ -22,7 +24,7 @@ export class TypegooseCoreModule implements OnModuleDestroy {
const connectionNameProvider = {
provide: TYPEGOOSE_CONNECTION_NAME,
useValue: connectionName
}
};

const connectionProvider = {
provide: connectionName,
Expand All @@ -42,7 +44,7 @@ export class TypegooseCoreModule implements OnModuleDestroy {
const connectionNameProvider = {
provide: TYPEGOOSE_CONNECTION_NAME,
useValue: connectionName
}
};

const connectionProvider = {
provide: connectionName,
Expand Down Expand Up @@ -102,6 +104,12 @@ export class TypegooseCoreModule implements OnModuleDestroy {

if (connection) {
await connection.close();
[...models.entries()].reduce((array, [key, model]) => {
if (model.db === connection) {
array.push(key);
}
return array;
}, []).forEach(deleteModel);
}
}
}
41 changes: 38 additions & 3 deletions test/app.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as request from 'supertest';
import {Test} from '@nestjs/testing';
import {Body, Controller, Module, Post} from '@nestjs/common';
import {InjectModel, TypegooseModule} from '../src';
import {prop} from '@typegoose/typegoose';
import {Body, Controller, INestApplication, Module, Post} from '@nestjs/common';
import {getModelToken, InjectModel, TypegooseModule} from '../src';
import {prop, ReturnModelType} from '@typegoose/typegoose';
import * as mongoose from 'mongoose';
import {Mockgoose} from 'mockgoose';

Expand Down Expand Up @@ -81,5 +81,40 @@ describe('App consuming TypegooseModule', () => {
expect(body.description).toBe('hello world');
});

afterAll(async () => {
await mockgoose.shutdown();
await app.close();
});
});

describe('Clear typegoose state after module destroy', () => {
let app: INestApplication;

beforeAll(async () => {
await mockgoose.prepareStorage();
});

beforeEach(async () => {
const moduleFixture = await Test.createTestingModule({
imports: [MockApp, MockSubModule]
}).compile();

app = moduleFixture.createNestApplication();
await app.init();
});

afterEach(async () => {
await app.close();
});

afterAll(() => mockgoose.shutdown());

Array.from({length: 2}).forEach(() => {
it('resolved model should use correct connection', async () => {
const model = await app.get(getModelToken(MockTypegooseClass.name));
await model.create({
description: 'test'
});
});
});
});
82 changes: 49 additions & 33 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,16 @@
consola "^2.3.0"
node-fetch "^2.3.0"

"@typegoose/typegoose@^6.0.0":
version "6.0.0"
resolved "https://registry.yarnpkg.com/@typegoose/typegoose/-/typegoose-6.0.0.tgz#2c0c840222c492fda04294bc0034c3a2ded5cb5f"
integrity sha512-EQCSCwmB6/5iriBAzwIY3MmKzDf8Y50wh/82xXkonIRgRD8aS7u2CgYPvNRASZPIxEF/jlROVDzKJ44TrInprA==
"@typegoose/typegoose@^6.1.1":
version "6.1.1"
resolved "https://registry.yarnpkg.com/@typegoose/typegoose/-/typegoose-6.1.1.tgz#7bc1bfc0db966e6fa10177760c85fc8f70ed3382"
integrity sha512-nqmsgZFgS8ws/WletvSvKN9jw4rGkMoUZDvRNJOhXJnP0REz4sFGoKxrtUYyGZMMS0SMhh89JmyA5rZY/MACJA==
dependencies:
lodash "^4.17.15"
loglevel "^1.6.4"
reflect-metadata "^0.1.13"
semver "^6.3.0"
tslib "^1.10.0"

"@types/babel__core@^7.1.0":
version "7.1.3"
Expand Down Expand Up @@ -759,13 +762,6 @@ async@2.1.4:
dependencies:
lodash "^4.14.0"

async@2.6.2:
version "2.6.2"
resolved "https://registry.yarnpkg.com/async/-/async-2.6.2.tgz#18330ea7e6e313887f5d2f2a904bac6fe4dd5381"
integrity sha512-H1qVYh1MYhEEFLsP97cVKqCGo7KfCyTt6uEWqsTBr9SO84oK9Uwbyd/yCW+6rKJLHksBNUVWZDAjfS+Ccx0Bbg==
dependencies:
lodash "^4.17.11"

async@^1.5.2:
version "1.5.2"
resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a"
Expand Down Expand Up @@ -3540,7 +3536,7 @@ lodash.sortby@^4.7.0:
resolved "https://registry.yarnpkg.com/lodash.sortby/-/lodash.sortby-4.7.0.tgz#edd14c824e2cc9c1e0b0a1b42bb5210516a42438"
integrity sha1-7dFMgk4sycHgsKG0K7UhBRakJDg=

lodash@^4.14.0, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14:
lodash@^4.14.0, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15:
version "4.17.15"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz#b447f6670a0455bbfeedd11392eff330ea097548"
integrity sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==
Expand Down Expand Up @@ -3649,6 +3645,11 @@ memoizee@^0.4.14:
next-tick "1"
timers-ext "^0.1.5"

memory-pager@^1.0.2:
version "1.5.0"
resolved "https://registry.yarnpkg.com/memory-pager/-/memory-pager-1.5.0.tgz#d8751655d22d384682741c972f2c3d6dfa3e66b5"
integrity sha512-ZS4Bp4r/Zoeq6+NLJpP+0Zzm0pR8whtGPf1XExKLJBAczGMnSi3It14OiNCStjQjM6NU1okjQGSxgEZN8eBYKg==

merge-descriptors@1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/merge-descriptors/-/merge-descriptors-1.0.1.tgz#b00aaa556dd8b44568150ec9d1b953f3f90cbb61"
Expand Down Expand Up @@ -3800,32 +3801,33 @@ mongodb-prebuilt@^6.4.0:
spawn-sync "1.0.15"
yargs "^3.26.0"

mongodb@3.3.2:
version "3.3.2"
resolved "https://registry.yarnpkg.com/mongodb/-/mongodb-3.3.2.tgz#ff086b5f552cf07e24ce098694210f3d42d668b2"
integrity sha512-fqJt3iywelk4yKu/lfwQg163Bjpo5zDKhXiohycvon4iQHbrfflSAz9AIlRE6496Pm/dQKQK5bMigdVo2s6gBg==
mongodb@3.3.3:
version "3.3.3"
resolved "https://registry.yarnpkg.com/mongodb/-/mongodb-3.3.3.tgz#509cad2225a1c56c65a331ed73a0d5d4ed5cbe67"
integrity sha512-MdRnoOjstmnrKJsK8PY0PjP6fyF/SBS4R8coxmhsfEU7tQ46/J6j+aSHF2n4c2/H8B+Hc/Klbfp8vggZfI0mmA==
dependencies:
bson "^1.1.1"
require_optional "^1.0.1"
safe-buffer "^5.1.2"
optionalDependencies:
saslprep "^1.0.0"

mongoose-legacy-pluralize@1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/mongoose-legacy-pluralize/-/mongoose-legacy-pluralize-1.0.2.tgz#3ba9f91fa507b5186d399fb40854bff18fb563e4"
integrity sha512-Yo/7qQU4/EyIS8YDFSeenIvXxZN+ld7YdV9LqFVQJzTLye8unujAWPZ4NWKfFA+RNjh+wvTWKY9Z3E5XM6ZZiQ==

mongoose@^5.7.1:
version "5.7.1"
resolved "https://registry.yarnpkg.com/mongoose/-/mongoose-5.7.1.tgz#47f8feb3d28e9caf645859e4245a933b39c1797b"
integrity sha512-TJeZHb5h8UGH++ctngh2shgZuZmR9o0D8elxfkWzIpKB6QAFsJPmALtDuD6RYZTS33+CifhDdAMGqs3OpJ3cyQ==
mongoose@^5.7.9:
version "5.7.9"
resolved "https://registry.yarnpkg.com/mongoose/-/mongoose-5.7.9.tgz#c7b7684e079749a26cdcc59b7027aae5d2b8f0f8"
integrity sha512-wXYY4+IEvplbEEeOxLVOHBGosBDNn/DYgwKzBFgsamCTvRQZHbdw88m9xUH8Srza+jdKND73/4XbQLynPseRAQ==
dependencies:
async "2.6.2"
bson "~1.1.1"
kareem "2.3.1"
mongodb "3.3.2"
mongodb "3.3.3"
mongoose-legacy-pluralize "1.0.2"
mpath "0.6.0"
mquery "3.2.1"
mquery "3.2.2"
ms "2.1.2"
regexp-clone "1.0.0"
safe-buffer "5.1.2"
Expand All @@ -3837,10 +3839,10 @@ mpath@0.6.0:
resolved "https://registry.yarnpkg.com/mpath/-/mpath-0.6.0.tgz#aa922029fca4f0f641f360e74c5c1b6a4c47078e"
integrity sha512-i75qh79MJ5Xo/sbhxrDrPSEG0H/mr1kcZXJ8dH6URU5jD/knFxCVqVC/gVSW7GIXL/9hHWlT9haLbCXWOll3qw==

mquery@3.2.1:
version "3.2.1"
resolved "https://registry.yarnpkg.com/mquery/-/mquery-3.2.1.tgz#8b059a49cdae0a8a9e804284ef64c2f58d3ac05d"
integrity sha512-kY/K8QToZWTTocm0U+r8rqcJCp5PRl6e8tPmoDs5OeSO3DInZE2rAL6AYH+V406JTo8305LdASOQcxRDqHojyw==
mquery@3.2.2:
version "3.2.2"
resolved "https://registry.yarnpkg.com/mquery/-/mquery-3.2.2.tgz#e1383a3951852ce23e37f619a9b350f1fb3664e7"
integrity sha512-XB52992COp0KP230I3qloVUbkLUxJIu328HBP2t2EsxSFtf4W1HPSOBWOXf1bqxK4Xbb66lfMJ+Bpfd9/yZE1Q==
dependencies:
bluebird "3.5.1"
debug "3.1.0"
Expand Down Expand Up @@ -4919,6 +4921,13 @@ sane@^4.0.3:
minimist "^1.1.1"
walker "~1.0.5"

saslprep@^1.0.0:
version "1.0.3"
resolved "https://registry.yarnpkg.com/saslprep/-/saslprep-1.0.3.tgz#4c02f946b56cf54297e347ba1093e7acac4cf226"
integrity sha512-/MY/PEMbk2SuY5sScONwhUDsV2p77Znkb/q3nSVstq/yQzYJOH/Azh29p9oJLsl3LnQwSvZDKagDGBsBwSooag==
dependencies:
sparse-bitfield "^3.0.3"

sax@^1.2.4:
version "1.2.4"
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
Expand All @@ -4943,7 +4952,7 @@ semver-greatest-satisfied-range@^1.1.0:
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
integrity sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ==

semver@^6.0.0, semver@^6.2.0:
semver@^6.0.0, semver@^6.2.0, semver@^6.3.0:
version "6.3.0"
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw==
Expand Down Expand Up @@ -5113,6 +5122,13 @@ sparkles@^1.0.0:
resolved "https://registry.yarnpkg.com/sparkles/-/sparkles-1.0.1.tgz#008db65edce6c50eec0c5e228e1945061dd0437c"
integrity sha512-dSO0DDYUahUt/0/pD/Is3VIm5TGJjludZ0HVymmhYF6eNA53PVLhnUk0znSYbH8IYBuJdCE+1luR22jNLMaQdw==

sparse-bitfield@^3.0.3:
version "3.0.3"
resolved "https://registry.yarnpkg.com/sparse-bitfield/-/sparse-bitfield-3.0.3.tgz#ff4ae6e68656056ba4b3e792ab3334d38273ca11"
integrity sha1-/0rm5oZWBWuks+eSqzM004JzyhE=
dependencies:
memory-pager "^1.0.2"

spawn-sync@1.0.15:
version "1.0.15"
resolved "https://registry.yarnpkg.com/spawn-sync/-/spawn-sync-1.0.15.tgz#b00799557eb7fb0c8376c29d44e8a1ea67e57476"
Expand Down Expand Up @@ -5568,7 +5584,7 @@ ts-jest@^24.1.0:
semver "^5.5"
yargs-parser "10.x"

tslib@^1.8.0, tslib@^1.8.1, tslib@^1.9.0:
tslib@^1.10.0, tslib@^1.8.0, tslib@^1.8.1, tslib@^1.9.0:
version "1.10.0"
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.10.0.tgz#c3c19f95973fb0a62973fb09d90d961ee43e5c8a"
integrity sha512-qOebF53frne81cf0S9B41ByenJ3/IuH8yJKngAX35CmiZySA0khhkovshKK+jGCaMnVomla7gVlIcc3EvKPbTQ==
Expand Down Expand Up @@ -5636,10 +5652,10 @@ typedarray@^0.0.6:
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@3.4.3:
version "3.4.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.3.tgz#0eb320e4ace9b10eadf5bc6103286b0f8b7c224f"
integrity sha512-FFgHdPt4T/duxx6Ndf7hwgMZZjZpB+U0nMNGVCYPq0rEzWKjEDobm4J6yb3CS7naZ0yURFqdw9Gwc7UOh/P9oQ==
typescript@3.5.3:
version "3.5.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==

uglify-js@^3.1.4:
version "3.6.0"
Expand Down