Simplify the version command output
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `version` command is generally expected to be just a simple print of the application version. In particular, it should not trigger the auto-sync that occurs when loading the `gopass` configuration in order to show the command versions for the configured mounts. Instead, the version info for the mount points is now displayed by a separate `mounts versions` sub-command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users expect the
versioncommand to display just the static version of the application, and it should run quickly with no additional overhead. Including information about the mounted password-stores requires additional initialization, and often triggers an auto-sync, which seems silly when you just need the app version.This splits the current version info into 2 separate commands:
gopass versiondisplays just the app version, requires no extra initialization, and will not trigger auto-sync or reminders.gopass mounts versionsshows the additional version info for the password-store mounts.