Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT: rename BaseBoundService internal attributes to avoid name clashing πŸ§‘β€πŸ’» #97

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

eigenein
Copy link
Member

No description provided.

@eigenein eigenein self-assigned this Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (94f86c2) 92.44% compared to head (2742950) 92.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files          32       32           
  Lines         807      807           
  Branches      120      120           
=======================================
  Hits          746      746           
  Misses         42       42           
  Partials       19       19           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@eigenein eigenein merged commit 98529ac into main Nov 17, 2023
12 checks passed
@eigenein eigenein deleted the opt/rename-protocol-classvar branch November 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant