Remove obsolete/invalid parameters from setPilot to fix #6 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent upgrade to the A19 bulbs breaks this code. If the parameters "sceneId":0,"c":0,"w":0 are sent to the bulb, it returns 'Invalid params' and fails.
|
Fixed the issue I was facing. Thanks 👍 |
|
I'm ready for any update offered for Hoobs! I have a lot of these WIZ bulbs that worked in Homekit with Hoobs before the WIZ App update. Out with the old! In with the new! |
MoTechnicalities
approved these changes
Jul 18, 2020
|
Not working for me sadly :(. Anything else I can try? I'm using A.E27 and CA.E14, which worked before. |
|
I have several A19s and this was the exact fix. Nice work, and thank you! |
kpsuperplane
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
Thank you so much for looking into this, I have unfortunately switched to Hue at this point and was unable to look into this.
If you (or anyone else) is interested in taking over this repo and project please let me know via an email (hello@kevinpei.com) or by creating an issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent upgrade to the A19 bulbs breaks this plugin. Some bulbs no longer respond to Homekit control via this plugin. (#6)
My investigation found that the new upgrade made changes to the requirements of the parameters. If the parameters
"sceneId":0,"c":0,"w":0are sent to the bulb, it returns 'Invalid params' and fails.By removing these parameters, this plugin works again on A19.
Reviews are required before merging this PR. I don't have other models of the bulb so I do not know if it will break old firmware. Please provide feedback!