Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s.io dependencies. #1540

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Upgrade k8s.io dependencies. #1540

merged 3 commits into from
Mar 18, 2021

Conversation

etefera
Copy link
Contributor

@etefera etefera commented Mar 11, 2021

Removes a replace directive that breaks go install. Fixes #1535
Changes the namespace in a test to reflect a change in one of the dependencies.

@etefera etefera requested a review from mortent March 11, 2021 09:26
@Liujingfang1
Copy link
Contributor

The change in pkg/live/dual-delegating-loader_test.go looks good to me.

@mortent
Copy link
Contributor

mortent commented Mar 11, 2021

This looks good to me. @etefera, can you also update the libraries from k8s in https://github.com/kubernetes-sigs/cli-utils and make sure all the tests pass there before we merge this one?

@etefera
Copy link
Contributor Author

etefera commented Mar 16, 2021

This looks good to me. @etefera, can you also update the libraries from k8s in https://github.com/kubernetes-sigs/cli-utils and make sure all the tests pass there before we merge this one?

kubernetes-sigs/cli-utils#337 is merged in and good to go

@mortent
Copy link
Contributor

mortent commented Mar 18, 2021

@etefera I think we should just update the cli-utils version as part of this PR too. So we can use the version of cli-utils which is based on the same version of the k8s libraries. We will have to rely on an unreleased version, but that is ok and we will address that when we do a release.

@etefera
Copy link
Contributor Author

etefera commented Mar 18, 2021

@etefera I think we should just update the cli-utils version as part of this PR too. So we can use the version of cli-utils which is based on the same version of the k8s libraries. We will have to rely on an unreleased version, but that is ok and we will address that when we do a release.

Updated with the results of go get sigs.k8s.io/cli-utils@70426d6 with tests still passing locally.

@etefera etefera merged commit 0dce033 into kptdev:master Mar 18, 2021
@etefera etefera deleted the broken-mod branch March 18, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod replace directive breaks go 1.16 module aware install
3 participants