kpt fn render includes local and meta resources by default
#2781
Conversation
| @@ -92,12 +92,18 @@ func (e *Executor) Execute(ctx context.Context) error { | |||
| at := attribution.Attributor{Resources: hctx.root.resources, CmdGroup: "fn"} | |||
| at.Process() | |||
|
|
|||
| includeMetaResources := true | |||
There was a problem hiding this comment.
will this eventually be changed as a configurable flag? Or kpt always include meta resources in fn render
There was a problem hiding this comment.
at the moment no plans to make it configurable.
There was a problem hiding this comment.
Actually, thought some more and realized exposing this as configurable flag will make it consistent with other fn commands and also provide a way to address the breaking change. Users can run fn render --include-meta-resources false to get the previous behavior. I will update the PR.
droot
force-pushed
the
fn-enable-meta-resources
branch
3 times, most recently
from
b627961
to
8a45dd9
Compare
|
ref: #2590 |
droot
changed the title
kpt fn render includes local and meta resources by default
droot
force-pushed
the
fn-enable-meta-resources
branch
from
14592a9
to
825e9ae
Compare
|
Quick update: Now this PR is against the target feature branch |
|
/lgtm |
internal/cmdrender/executor.go
Outdated
| fnResults: fnresult.NewResultList(), | ||
| imagePullPolicy: e.ImagePullPolicy, | ||
| allowExec: e.AllowExec, | ||
| encludeMetaResources: e.ExcludeMetaResources, |
There was a problem hiding this comment.
Thanks for catching it.
internal/cmdrender/executor.go
Outdated
| @@ -168,6 +176,10 @@ type hydrationContext struct { | |||
| // imagePullPolicy controls the image pulling behavior. | |||
| imagePullPolicy fnruntime.ImagePullPolicy | |||
|
|
|||
| // indicate if package meta resources such as Kptfile | |||
| // to be excluded from the function in put during render. | |||
| encludeMetaResources bool | |||
This PR adds support for including
localandmetaresources by default infn render.To exclude meta resource (just the
Kptfile), users can runkpt fn render --exclude-meta-resources.