-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip the tests in the thirdparty directory #3049
Conversation
From my PR CI results, it seems like some tests are flakey |
@yuwenma Do you have a link that I can look at? |
Aha, fortunately I have another open PR: All three PRs have the same failure on go build |
@mengqiy I pasted the flaky test log here https://paste.googleplex.com/6427926082879488 and reran the job. |
It seems this tese case is causing some issue. I found this test case was modified after the version we are using. kubernetes-sigs/cli-utils@7aee3cc#diff-c1319f0853b5d0fa77470af5ed385b3bd933f6e864978c885e7c745d49ecd021L878 |
@karlkfi Do you have any insight? If this test case was flaky, and kubernetes-sigs/cli-utils@7aee3cc#diff-c1319f0853b5d0fa77470af5ed385b3bd933f6e864978c885e7c745d49ecd021L878 helps mitigated it? Here is an example failure: https://github.com/GoogleContainerTools/kpt/runs/6120096965?check_suite_focus=true#step:4:339 We are trying to figure out if it is the k8s RC release or something else causing the problem. |
Looks like the test have failed in cli-utils as well: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cli-utils/572/cli-utils-presubmit-master/1514747907578793984, so it is probably a bit flaky. But overall the cli-utils tests are mostly passing: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/cli-utils-presubmit-master |
This looks like a problem I ran into recently while working on my watcher PR (kubernetes-sigs/cli-utils#572). The issue is probably that the ApplyTask takes long enough that the objec tis already reconciled before the WaitTask starts, which means the WaitTask skips the ReconcilePending event and goes strait to the ReconcileSuccessful event. It occurs to me that cli-utils doesn't have periodic tests on master, so we might not have caught that the test was flaky. On the plus side, the code is probably fine. So you can fix the test or just comment it out. |
oh wait... missing Current StatusEvent is different that missing Pending WaitEvent... nevermind what I said... I don't know what the cause it for this. |
You might want to change the |
Sure. #3050 |
I was able to repro locally once, after trying many times:
|
Ahh, i see what the problem is. So the fix is probably to just remove the statusEvents & expectedStatusEvents for this test. |
Closing this PR in favor of #3059. |
No description provided.