fix: Avoid race condition in applier test #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
karlkfi
commented
Apr 22, 2022
•
karlkfi
commented
- Fixed a race condition. See comment.
- Changed a few Fatalf to Errorf to make it easier to debug with all the errors.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
karlkfi
force-pushed
the
karl-fix-flaky-applier-test
branch
from
a641373
to
db1ae2b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
mengqiy
pushed a commit
to mengqiy/kpt
that referenced
this pull request
Apr 25, 2022
mengqiy
pushed a commit
to mengqiy/kpt
that referenced
this pull request
Apr 25, 2022
mengqiy
pushed a commit
to kptdev/kpt
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.