packagevariantset controller: support arbitrary object selectors #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
force-pushed
the
PVSObjectSet
branch
4 times, most recently
from
ca33715
to
9867797
Compare
|
@mortent I plan to run this through a few more scenarios on Monday to be more confident, but seems to work so far, so this is ready for review! |
mortent
reviewed
Feb 8, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
...rs/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller_test.go
Outdated
Show resolved
Hide resolved
natasha41575
force-pushed
the
PVSObjectSet
branch
from
9867797
to
5b77831
Compare
natasha41575
force-pushed
the
PVSObjectSet
branch
from
5b77831
to
431eb4d
Compare
mortent
reviewed
Feb 18, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
natasha41575
force-pushed
the
PVSObjectSet
branch
from
c4d0f24
to
b2d12e9
Compare
natasha41575
force-pushed
the
PVSObjectSet
branch
from
b2d12e9
to
30e2e1d
Compare
mortent
approved these changes
Feb 24, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for using arbitrary objects in the cluster as input to the PackageVariantSet controller (option 3 for targets).
Related issue: #3488