Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packagerevisions for repos with subdirs #4097

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

johnbelamaric
Copy link
Contributor

When the same underlying git repository is registered multiple times with different directory values, all of the package revisions from one of the directories were showing up multiple times, and none from the others.

The issue is that the cache was mapping them all to the same underlying gitRepository, which is not correct. This separates them properly. It means extra polling of the same repo, but that's OK. Doing it any other way would be more complicated, especially when you consider there could be different permissions for each registration.

The "load" counts were also wrong in this case, fixed that too.

Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants