Fix bit packing and quantize on big endian. #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitPackShift() doesn't return the right value on big endian for
{Read,Write}Int25. Consecutive25 would just fail on big endian.
The fix is to round it to 32 instead 64.
Using a WriteInt57 and Two ReadInt25 to read the combined integer value
won't simply work on big endian. The fix just simply replace the
WriteInt57 with two ReadInt25 for MiddlePointer.