Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash when trying to create a workspace in 3.8 #167

Closed
trag1c opened this issue Jan 24, 2024 · 3 comments · Fixed by #168
Closed

[BUG] Crash when trying to create a workspace in 3.8 #167

trag1c opened this issue Jan 24, 2024 · 3 comments · Fixed by #168
Labels
bug Something isn't working

Comments

@trag1c
Copy link

trag1c commented Jan 24, 2024

To Reproduce 🐣
Steps to reproduce the behavior:

  1. Run dooit in Python 3.8
  2. Try creating a workspace by pressing a
  3. See error

Desktop (please complete the following information): 🤖

  • OS: macOS
  • Version: 14.2.1

Additional context 📝
Related issue: #161

The error seems to be caused by this snippet:

dooit/dooit/api/model.py

Lines 79 to 82 in b1ea932

@classmethod
@property
def class_kind(cls) -> str:
return cls.__name__.lower()

Stacking @classmethod on top of @property to get a class property is only supported in Python 3.9–3.10 (though it works in 3.11+ for now, see the changes mentioned in the docs).

@trag1c trag1c added the bug Something isn't working label Jan 24, 2024
bswck added a commit to bswck/dooit that referenced this issue Jan 24, 2024
@kraanzu
Copy link
Owner

kraanzu commented Jan 25, 2024

Ah I see now, one other person was having the same issue and I had no idea why #161
But when I told him to use the binary, it worked for him!

Thanks!

eklairs added a commit that referenced this issue Jan 25, 2024
Set `class_kind` in `__init_subclass__` (#167)
@trag1c
Copy link
Author

trag1c commented Jan 25, 2024

Yes, I've mentioned that issue in the description here 👍

You're welcome.

@trag1c trag1c closed this as completed Jan 25, 2024
Copy link

Did we solve your problem?
Glad we could help!

Consider sponsoring my work through github sponsors 😄
@kraanzu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants