Only loading frames once, added bounds check to CR.

kragen · Feb 15, 2011 · 237e7a5 · 237e7a5
1 parent 6653bdc
commit 237e7a5
Showing 1 changed file with 20 additions and 10 deletions.
diff --git a/ttyplayer.js b/ttyplayer.js
@@ -5,8 +5,8 @@ function TTYPlayer () {
 
     var timeout = null;
 
-    var frame = $('#frame');
     var buffer = [[]];
+
     var output = '';
     var pre_pend = '';
     var point = {
@@ -29,6 +29,15 @@ function TTYPlayer () {
     var HEIGHT = 24;
     var WIDTH = 80;
 
+    var frames = {};
+
+    for (var i = 1; i <= HEIGHT; i++) {
+        for (var j = 1; j <= WIDTH; j++) { 
+            var x = i + '_' + j;
+            frames[x] = $('#f' + x);
+        }
+    }
+
     var render_frame = function (string) {
         string = pre_pend + string;
         pre_pend = '';
@@ -108,6 +117,10 @@ function TTYPlayer () {
                         point.x = 1;
                         point.y++;
 
+                        if (point.y > HEIGHT) {
+                            point.y = HEIGHT;
+                        }
+
                         if (buffer[point.y - 1] == undefined) {
                             buffer[point.y - 1] = [];
                         }
@@ -599,14 +612,14 @@ function TTYPlayer () {
                             c = '<span>&nbsp;</span>';
                         }
 
-                        var f = $('#f' + i + '_' + j);
+                        var f = frames[i + '_' + j];
                         f.html(c);
                     }
                 }
 
                 for (var i = 1; i + m <= HEIGHT; i++) {
                     for (var j = 1; j <= WIDTH; j++) { 
-                        var f = $('#f' + (i + m) + '_' + j);
+                        var f = frames[(i + m) + '_' + j];
                         f.html('<span>&nbsp;</span>');
                     }
                 }
@@ -627,24 +640,21 @@ function TTYPlayer () {
                         c = '<span>&nbsp;</span>';
                     }
 
-                    var f = $('#f' + i + '_' + j);
+                    var f = frames[i + '_' + j];
                     f.html(c);
                 }
 
                 for (var line in update_lines) {
                     var i = parseInt(line);
 
                     for (var j = 1; j <= WIDTH; j++) {
-                        if (index == 12) {
-                            var foo = true;
-                        }
 
                         var c = buffer[i - 1][j - 1];
                         if (c == undefined) {
                             c = '<span>&nbsp;</span>';
                         }
 
-                        var f = $('#f' + i + '_' + j);
+                        var f = frames[i + '_' + j];
                         f.html(c);
                     }
                 }
@@ -727,9 +737,9 @@ function TTYPlayer () {
 
         console.log('Wait ' + millisec + ' milliseconds.');
 
-        if (index < 321) {
+        // if (index < 20) {
             timeout = window.setTimeout(play_data, millisec);
-        }
+        // }
     };
 
     var stop_data = function() {