-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcxx: fails in configure when create-spdx is enabled #721
Comments
this just happened in another build
seems like a race to me |
this might be unrelated to the original issue, but I think all recipes that include |
@witekio-kwe thanks for the report. I wonder how it works ok for gcc recipes, there we use similar method of shared workdir |
@kraj that’s the code - gcc exceptions are hardcoded :-( |
@witekio-kwe thats explains thanks for digging. Perhaps you can propose such an exception for clang related recipes too ? |
Let me thoroughly test my local patches and then I will draft a PR |
@kraj I found why the configure task fails (had the same kind of issue now with clang-native and compiler-rt). Normally upstream code does unpack the sources into a temporary dir under
in all the recipes affected only The assumption that WORKDIR needs to have work-shared might be error prone but it’s not wrong - at the same time just setting I helped myself with the following additions to common-source.inc
but this feels like a work around, so I’m hesitant to put that into a PR. That brings me to my question, can we set A second option would be remove |
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Closes kraj#721
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Relates to kraj#721
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Relates to kraj#721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Closes kraj#721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Relates to #721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Closes kraj#721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Relates to kraj#721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com> (cherry picked from commit b7c0dcc)
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Relates to #721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com> (cherry picked from commit b7c0dcc)
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Closes kraj#721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
- do_create_spdx does have to wait till the shared source tree is properly populated - override the spdx class code detection to determine if sources are under work-shared. the core code does only look at WORKDIR, which isn’t overridden in every case, more likely only S and B are touched, which make the spdx class code assume that these are per-workdir sources and starts to remove the shared sources via bitbake’s cleandirs settings. Avoid that by let the code always handle recipes including common-source as shared sources. Closes #721 Signed-off-by: Konrad Weihmann <kweihmann@witekio.com>
Describe the bug
when
create-spdx
class is inherited globally, libcxx fails to configure.This happens after an upgrade from c728c3f to bc8388c in
kirkstone
branch.As to be seen in the attached log configure can’t find certain paths in the llvm-project-source shared folder.
I just checked they really do not exist in this case.
If the create-spdx tasks are deleted (the workaround I chose) or create-spdx isn’t part of the configuration, everything works fine even with the upgrade to kirkstone head.
Interestingly, even though many use the shared sources, only libcxx fails
DISTRO: poky
MACHINE: qemux86-64
LAYERS: core, poky, yocto-bsp, meta-clang
To Reproduce
Steps to reproduce the behavior:
libcxx
Expected behavior
configure doesn’t fail when create-spdx tasks are enabled
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: