Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep kraken-wrapper in its own package after all, remove kraken-{core,std,common} packages completely #141

Merged
merged 15 commits into from
Dec 14, 2023

Conversation

NiklasRosenstein
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein commented Dec 13, 2023

> Drop kraken-{common,core,std} packages entirely

With the minor upgrade we can relatively safely get rid of the placeholders for kraken-{core,std,common} because nothing explicitly depends on it, and if it does it's still going to resolve their old versions.

> Keep kraken-wrapper in its own package

Not having kraken-wrapper live in its own package has the issue that Pipx will not link it's krakenw console script into the user's script directory unless you add the --include-deps flag, but none of our documentation and what our users are used to contain that information. We could re-export the entrypoint in the kraken-wrapper package's entrypoints, but then there's not really a good reason to keep the wrapper code into the repository, especially considering that it pulls in a number of additional dependencies that you don't need in your build environment.

> Consistent Kraken usage in repository

In addition, I'm changing the repository so that all installing/formatting/linting/testing is done by Kraken as well, reusing the .kraken.py we had for kraken-std originally and had moved into kraken-build, as well as adding the docs/ directory as a subproject.

I've also update the docs/ subproject to integrate neatly with the root Kraken project (so now you can run krakenw run :docs:serve to view the docs).

> Cut changelog history before 0.20.0

Who's still interested in the changelog for Kraken 0.12.4?

NiklasRosenstein and others added 3 commits December 13, 2023 23:36
…its own package, remove `kraken-core`, `kraken-common` and `kraken-std` (those are not usually depended on directly at the moment anyway)
@NiklasRosenstein NiklasRosenstein changed the title nr/fix 0.32 Keep kraken-wrapper in its own package after all, remove kraken-{core,std,common} packages completely Dec 13, 2023
@NiklasRosenstein NiklasRosenstein marked this pull request as ready for review December 14, 2023 00:13
@NiklasRosenstein
Copy link
Contributor Author

The "Changelog / Insert Pull Request URL into new changelog entries (pull_request_target)" job will keep failing until it is merged because the source of the job definition is taken from the default branch.

@NiklasRosenstein NiklasRosenstein merged commit a706ce7 into develop Dec 14, 2023
6 of 7 checks passed
@NiklasRosenstein NiklasRosenstein deleted the nr/fix-0.32 branch December 14, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant