-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep kraken-wrapper in its own package after all, remove kraken-{core,std,common}
packages completely
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its own package, remove `kraken-core`, `kraken-common` and `kraken-std` (those are not usually depended on directly at the moment anyway)
skip-checks: true
NiklasRosenstein
changed the title
nr/fix 0.32
Keep kraken-wrapper in its own package after all, remove Dec 13, 2023
kraken-{core,std,common}
packages completely
…aph commands (e.g. `kraken run` and the `kraken query` commands) that made the argument not recognized.
… fix docs .kraken.py
The "Changelog / Insert Pull Request URL into new changelog entries (pull_request_target)" job will keep failing until it is merged because the source of the job definition is taken from the default branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
> Drop
kraken-{common,core,std}
packages entirelyWith the minor upgrade we can relatively safely get rid of the placeholders for
kraken-{core,std,common}
because nothing explicitly depends on it, and if it does it's still going to resolve their old versions.> Keep
kraken-wrapper
in its own packageNot having
kraken-wrapper
live in its own package has the issue that Pipx will not link it'skrakenw
console script into the user's script directory unless you add the--include-deps
flag, but none of our documentation and what our users are used to contain that information. We could re-export the entrypoint in thekraken-wrapper
package's entrypoints, but then there's not really a good reason to keep the wrapper code into the repository, especially considering that it pulls in a number of additional dependencies that you don't need in your build environment.> Consistent Kraken usage in repository
In addition, I'm changing the repository so that all installing/formatting/linting/testing is done by Kraken as well, reusing the
.kraken.py
we had forkraken-std
originally and had moved intokraken-build
, as well as adding thedocs/
directory as a subproject.I've also update the
docs/
subproject to integrate neatly with the root Kraken project (so now you can runkrakenw run :docs:serve
to view the docs).> Cut changelog history before 0.20.0
Who's still interested in the changelog for Kraken 0.12.4?