Resolve: Add option to configure key caching duration (#24)

[foxcool]

This PR is just adds cacheDuration parameter. When specified, the default value (15 minutes) is replaced.

[foxcool]

Also 1 test in master is failed

=== RUN TestJWK
--- FAIL: TestJWK (0.00s)
jwk_test.go:15: open cert.pem: no such file or directory

is it ok?

[kpacha]

@foxcool I think this is a great idea and I'm loving you make it backward compatible. On the other side, I think the TTL should not be too long in order to properly react to a rotation of the keys

regarding your comment, there is a test that requires a cert and key. They are generated with this line from the jwk_test.go:

//go:generate go run $GOROOT/src/crypto/tls/generate_cert.go --rsa-bits 1024 --host 127.0.0.1,::1,localhost --ca --start-date "Jan 1 00:00:00 1970" --duration=1000000h

the CI config calls go generate before launching the test suite

https://github.com/devopsfaith/krakend-jose/blob/master/.travis.yml#L11-L13

[foxcool]

I accept a duration value of less than a second. Maybe I need to increase the step to a second?

[kpacha]

I'd change the type of the new property and instead of using a time.Duration I'd go with a plain int representing minutes.

otherwise, the duration will be defined in nanoseconds (https://play.golang.org/p/Hw0QJ7XDgdE)

[foxcool]

I'd change the type of the new property and instead of using a time.Duration I'd go with a plain int representing minutes.

otherwise, the duration will be defined in nanoseconds (https://play.golang.org/p/Hw0QJ7XDgdE)

Yes, this is what I meant in the previous comment. A nanosecond is too small a step. But the minute, it seems to me, is too large. Maybe a second is better?

[kpacha]

ouch, I did not understand you... 😄

I think it's ok to use seconds instead of minutes.

[kpacha]

thanks for the contribution!

[github-actions]

This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.