This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Changes for 1.x #84
Merged
Changes for 1.x #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exported for testing as `engine.dust`
Support for dustjs 2.7.1, breaking compatibility
…is tied closely anyway, allowing our user to provide and vary it is bad.
Add support for renderOptions
Add actual dependency on dustjs-linkedin since version compatibility is tied closely anyway, allowing our user to provide and vary it is bad.
… forcing it on and looking for results in dust.cache
Simplify caching
Fix a couple more places dust was required
Support for inline function
| We intentionally didn't add the dependency to this module's package.json such that we didn't want to be in control of it or its versions on behalf of apps. That way app owners can manage the dependency however they see fit and this module can just "enhance" the existing library. It does assume the version of dust.js doesn't change template loading or streaming behavior, but beyond that compatibility should be fine. If there IS a major version change to dust APIs we'll be sure to manage those changes here, so the upgrade/handling of it is transparent. | ||
| * Removed the `layout:` option to render and in configuration | ||
| * Dust is our own private instance, not global. If you load helpers, you must do it in the configuration of adaro. | ||
| * We outright require dust. We will not use your application's instslled version. |
|
|
||
| function createRenderContext(options) { | ||
| var context; | ||
| var freshy = require('freshy').freshy; |
There was a problem hiding this comment.
mix of styles for variable declaration and line breaks. I like a declaration per line, between the two styles. not necessary to address for merge, just noting it in case you feel like tightening this up.
There was a problem hiding this comment.
Yeah, may do that. I dislike it too, but change for change's sake never grabbed me. Might be time now.
…ching can be made uniform
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.