This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Add support for locale groups #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Sweet! If you publish this, this clears a user's bug! |
|
OK will do. |
|
should we consider this as a patch or a minor release? it feels like a patch but of course it could change the behavior of the middleware for some |
|
Hm. That'd make it technically breaking but distantly unlikely; does add a feature, I'm inclined to say minor. |
|
OK. What bug does this fix so I can reference in the changelog? |
|
It allows locales like |
|
oh of course. that's clear from the unit test. i just thought maybe an issue had been filed on another module (since there was none filed here) |
|
Nope. I may have beaten them to the punch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.