Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on server side #11

Merged
merged 3 commits into from
Jul 21, 2018
Merged

Fix error on server side #11

merged 3 commits into from
Jul 21, 2018

Conversation

shrpne
Copy link
Contributor

@shrpne shrpne commented Mar 16, 2018

I have an issue with this polyfill using it with SSR.
I have added a simple check, so now it does nothing when running in the Node.js environment.

@kumarharsh
Copy link
Collaborator

In the meanwhile, you can use this fork which has @andrejpavlovic and @shrpne's changes
https://www.npmjs.com/package/@playlyfe/custom-event-polyfill

@evocateur
Copy link

evocateur commented May 23, 2018

This fix is not sufficient to guard an actual node.js server environment, you need to use typeof window === ‘undefined’ instead of !window

@shrpne
Copy link
Contributor Author

shrpne commented May 23, 2018

Thanks! I've updated this check

@kumarharsh
Copy link
Collaborator

Has been merged in my fork. New version released.

@krambuhl krambuhl merged commit a09711a into krambuhl:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants