minInclusive on a type xs:gYearMonth

[kalgon]

Hi,

I have a schema with the following type:

<xs:restriction base="xs:gYearMonth">
  <xs:minInclusive value="1911-01"/>
  <xs:pattern value="\d{4}-\d{2}"/>
</xs:restriction>

this generates an annotation @DecimalMin("1911-01") which will throw a NumberFormatException because 1911-01 cannot be converted to a BigDecimal value although "1911-01" is a legal minInclusive value for xs:gYearMonth (see http://books.xmlschemata.org/relaxng/ch19-77135.html).

What would be the solution?

• have a custom annotation for this case?
• not adding the @DecimalMin annotation when the value is not a BigDecimal?

Thanks,

Xavier

[krasa]

Hi,
As far as I know, bean validations supports only @past and @future, so @DecimalMin should not be generated. I will fix that. (ETA 10 hours)

It would be nice to implement some custom annotation. Pull requests are welcomed :)

[kalgon]

I think the way of the custom annotation is inevitable as I stumbled upon another problem with xs:choice:

<xs:complexType name="DrinkType">
  <xs:sequence>
    <xs:choice>
      <xs:element ref="Tea"/>
      <xs:element ref="Coffee"/>
    </xs:choice>
  </xs:sequence>
</xs:complexType>

which generates:

public class DrinkType {
  @NotNull Tea tea;
  @NotNull Coffee coffee;
}

I think something like this would be better:

@Choice({"tea", "coffee"})
public class DrinkType {
  Tea tea;
  Coffee coffee;
}

Xavier

[krasa]

Date is fixed in 0.5-SNAPSHOT

[krasa]

Fixing the choice will be very hard.

[krasa]

so @NotNull at choices is fixed.

[hestad]

Do you see any solution on the @Choice-issue? Btw, I think this issue should have been split into two issues.

[krasa]

Well I do not have solution, but I think it should be possible. I have even seen some ugly way how to find out what is defined as choice....
Contributions are welcomed.

And you are right, I will split it.