Skip to content

Commit

Permalink
Fix leak in ulog_replay()
Browse files Browse the repository at this point in the history
ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
should not also do so.

(cherry picked from commit 2908839)

ticket: 8441
version_fixed: 1.13.7
  • Loading branch information
greghudson authored and tlyu committed Sep 2, 2016
1 parent 92ed15d commit d3b8c7c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/lib/kdb/kdb_log.c
Original file line number Diff line number Diff line change
Expand Up @@ -387,10 +387,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
if (retval)
goto cleanup;
} else {
entry = k5alloc(sizeof(krb5_db_entry), &retval);
if (entry == NULL)
goto cleanup;

retval = ulog_conv_2dbentry(context, &entry, upd);
if (retval)
goto cleanup;
Expand Down

0 comments on commit d3b8c7c

Please sign in to comment.