-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix kdb5_ldap_util stashsrvpw password file logic
kdb5_ldap_util stashsrvpw has several inconsistencies with the password file determination in libkdb_ldap, and could try to fopen() a NULL filename in some cases. Factor out the determination of the configured password file and make it consistent with libkdb_ldap. DEF_SERVICE_PASSWD_FILE is no longer used after these changes, as it is not respected by libkdb_ldap. Reported by Will Fiveash. ticket: 8295
- Loading branch information
1 parent
9a892a3
commit e2d7a66
Showing
2 changed files
with
49 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2d7a66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given Solaris has used "service_passwd" as the default ldap service password file for a long time, would it be possible to add support to the configure script to allow an override of the current default of "ldap_service_password_file" so we don't have to patch this?
e2d7a66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently no default recognized by libkdb_ldap (or by kdb5_ldap_util after this commit). Would a default of "service_passwd" in the KDC directory agree with Solaris?
e2d7a66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.