Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1121 score screen #1217

Merged
merged 35 commits into from
Jul 5, 2021
Merged

Feature 1121 score screen #1217

merged 35 commits into from
Jul 5, 2021

Conversation

kreghek
Copy link
Owner

@kreghek kreghek commented Jul 1, 2021

Part of #1120
Part of #1121

Changes

  • ...

Checklist

@kreghek kreghek added client Works on client core Нужны доработки корневого функционала labels Jul 1, 2021
@kreghek kreghek self-assigned this Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1217 (6b727b1) into master (259bc48) will increase coverage by 0.05%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
+ Coverage   63.50%   63.55%   +0.05%     
==========================================
  Files         347      347              
  Lines        8006     8034      +28     
==========================================
+ Hits         5084     5106      +22     
- Misses       2922     2928       +6     
Flag Coverage Δ
Zilon.Core.FunctionalTests 39.93% <0.00%> (-0.14%) ⬇️
Zilon.Core.UnitTests 48.72% <81.25%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Core/Zilon.Core/Client/Sector/GlobeLoopUpdater.cs 0.00% <ø> (ø)
...ore/Zilon.Core/Client/Sector/CommandLoopUpdater.cs 81.81% <81.25%> (-2.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259bc48...6b727b1. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 1, 2021

Pull Request Test Coverage Report for Build 1001745906

  • 26 of 32 (81.25%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 59.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Zilon.Core/Zilon.Core/Client/Sector/CommandLoopUpdater.cs 26 32 81.25%
Totals Coverage Status
Change from base Build 977631783: 0.04%
Covered Lines: 5106
Relevant Lines: 8034

💛 - Coveralls

@kreghek kreghek merged commit b7f0c19 into master Jul 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Works on client core Нужны доработки корневого функционала
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants