Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

if bitcaskfile does not close in this function, when bitcask system shut... #1

Merged
merged 1 commit into from

2 participants

@wangscu

if bitcaskfile does not close in this function, when bitcask system shutdown, the file references in java can not release!

@wangscu wangscu if bitcaskfile does not close in this function, when bitcask system s…
…hutdown, the file references in java can not release!
c535951
@krestenkrab krestenkrab merged commit d1b0353 into krestenkrab:master
@krestenkrab
Owner

Maybe we should even add a try/catch block around that code and close in finally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 4, 2011
  1. @wangscu

    if bitcaskfile does not close in this function, when bitcask system s…

    wangscu authored
    …hutdown, the file references in java can not release!
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  src/main/java/com/trifork/bitcask/BitCask.java
View
3  src/main/java/com/trifork/bitcask/BitCask.java
@@ -237,7 +237,8 @@ public Void each(ByteString key, int tstamp, long entryPos,
return null;
}
}, null);
-
+
+ file.close();
}
}
Something went wrong with that request. Please try again.