Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move react to peerDependencies #156

Closed
wants to merge 2 commits into from
Closed

Move react to peerDependencies #156

wants to merge 2 commits into from

Conversation

tstirrat15
Copy link
Contributor

Fixes #155

Motivation

See #155. When react is a dependency of a React-related package, it's possible for multiple instances of React to end up floating around in the bundled/executed code. This isn't always a problem, but recent changes to hooks and context in React have made it that much more likely for it to become a problem.

Moving react to a peerDependency means that it's up to the consumer to install react, but it also makes it that much less likely that this library will cause problems in other people's applications.

Changes

  • Move React to a peerDependency

@codecov-io
Copy link

codecov-io commented Apr 24, 2019 •
edited
Loading

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files           3        3           
  Lines          52       52           
  Branches       12       12           
=======================================
  Hits           42       42           
  Misses          9        9           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5af84...a46acd9. Read the comment docs.

@frenzzy frenzzy mentioned this pull request May 21, 2019
Merged
@tstirrat15
Copy link
Contributor Author

Any news on this one?

@MYKEU MYKEU mentioned this pull request Aug 15, 2019
Open
@MYKEU
Copy link

MYKEU commented Aug 15, 2019

Any update regarding this?

@damiangreen
Copy link

This is now a problem with the latest react version

@piglovesyou
Copy link
Contributor

@frenzzy I believe this should be taken care of soon. React Starter Kit users may face multiple react version problem when they update dependencies.

@TylerShin
Copy link

any update?

@MYKEU
Copy link

MYKEU commented Oct 3, 2019

Any update regarding this yet?

@async3619 async3619 mentioned this pull request Oct 31, 2019
Open
@amillward
Copy link

Any update?

@damiangreen
Copy link

We forked it, you can use isomorphic-style-loader-forked as this library seems unmantained now

@dazlious
Copy link
Collaborator

dazlious commented Jul 9, 2021

As this seems to be unmaintained, I created a fork and published it. I needed the ability to use react-17 in my project.

https://www.npmjs.com/package/isomorphic-style-loader-react-17

@dazlious
Copy link
Collaborator

fixed in https://github.com/kriasoft/isomorphic-style-loader/releases/tag/v5.2.0-beta.1

@dazlious dazlious closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React should be a peer dependency, not a dependency
8 participants
@tstirrat15 @codecov-io @MYKEU @damiangreen @piglovesyou @TylerShin @amillward @dazlious