Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Still Work in Progress] Separating into loader and react-binder #160

Closed
wants to merge 15 commits into from

Conversation

piglovesyou
Copy link
Contributor

@piglovesyou piglovesyou commented Jun 1, 2019

Ref. #159

  • Share lint logic
  • Share test logic
  • Share build logic
  • Share *rc file as much as possible

@piglovesyou
Copy link
Contributor Author

piglovesyou commented Jun 12, 2019

I'm waiting for reply from @frenzzy before going forward.
#159 (comment)

@frenzzy
Copy link
Member

frenzzy commented Jun 14, 2019

Do you have an idea how to name a package with react components?
Oh lerna.. looks more complicated than how it is now.
Looks like isomorphic-style is taken and already does what we want.


I am waiting for [IN PROGRESS] CSS AS FIRST-CLASS CITIZEN in webpack which could be a game changer and make this package unnecessary.

Another question is why css-loader does not have an option to exclude runtime code from the bundle - this feature may help with rendering styles on both client and server-side too.

Also would be nice to do a research about other ways to extract critical path css with less overhead - for example without runtime code and with faster compilation, maybe even consider alternatives like css-in-js solutions.

I am still not sure about the future of isomorphic-style-loader and maybe it is better to leave it as is for now... 🤷‍♂️

@piglovesyou
Copy link
Contributor Author

@frenzzy I see, I understood you had more thoughts than last time you commented. I agree with you that separating loader and react-binding is definitely not emergency.

I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants