Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIDE_MODULE=2 ignores EXPORTED_FUNCTIONS and exports everything (+ no DCE) #5419

Closed
karelbilek opened this issue Jul 25, 2017 · 3 comments
Closed

SIDE_MODULE=2 ignores EXPORTED_FUNCTIONS and exports everything (+ no DCE) #5419

karelbilek opened this issue Jul 25, 2017 · 3 comments

Comments

@karelbilek
Copy link

karelbilek commented Jul 25, 2017 •
edited
Loading

When I compile with SIDE_MODULE=2, EXPORTED_FUNCTIONS seems to be completely ignored, everything is exported and the dead code elimination doesn't work - so everything is always included.
@karelbilek karelbilek changed the title SIDE_MODULE=2 ignores EXPORTED_FUNCTIONS and exports everything SIDE_MODULE=2 ignores EXPORTED_FUNCTIONS and exports everything (+ no DCE) Jul 25, 2017
@kripken kripken mentioned this issue Jul 26, 2017
Merged
@kripken
Copy link
Member

kripken commented Jul 26, 2017

Thanks for reporting, looks like this was indeed missing. Fix in #5422.

@nic-hartley
Copy link

@kripken looks like this is done, maybe it should be closed?

@kripken
Copy link
Member

kripken commented Feb 14, 2019

Thanks, closing.

@kripken kripken closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karelbilek @kripken @nic-hartley