Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closure fixes for wasm #5039

Merged
merged 1 commit into from
Mar 21, 2017
Merged

closure fixes for wasm #5039

merged 1 commit into from
Mar 21, 2017

Conversation

kripken
Copy link
Member

@kripken kripken commented Mar 15, 2017

Fixes binaryen2.test_ccall.

jgravelle-google
jgravelle-google approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@jgravelle-google jgravelle-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising. I guess it's because the closure compiler minifies the names if it doesn't see them used anywhere by string, and it doesn't know that WebAssembly is a browser API yet?

lgtm

@kripken
Copy link
Member Author

kripken commented Mar 15, 2017

Yeah. Although meanwhile I realized there's a better way, we can declare the wasm APIs for closure. We do still need to quote the arguments in the objects we pass, see commit.

@kripken kripken merged commit ebae5b7 into incoming Mar 21, 2017
@kripken kripken deleted the fix-wasm-closure branch March 21, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravelle-google jgravelle-google jgravelle-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @jgravelle-google