fix(typescript): type definition for FuseOptionKeyObject, fixes #655
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k#655 - Make `FuseOptionKeyObject.weight` property optional (and add description taken from docs) - Add `FuseOptionKeyObject.getFn` property (and add description taken from docs) - Add `FuseOptionKeyObjectGetFunction` type to match existing `FuseGetFunction` type - Make `FuseOptionKeyObject` a generic, to allow typing the `getFn` method argument - Make `FuseOptionKey` a generic, to allow making `FuseOptionKeyObject` a generic - Convert some existing inline comments `// foo` to jsdoc comments `/** foo */` so they will be included in intellisense
BenJenkinson
changed the title
FuseOptionKeyObject, fixes #655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FuseOptionKeyObject.weightproperty optional (and add description taken from docs)FuseOptionKeyObject.getFnproperty (and add description taken from docs)FuseOptionKeyObjectGetFunctiontype to match existingFuseGetFunctiontypeFuseOptionKeyObjecta generic, to allow typing thegetFnmethod argumentFuseOptionKeya generic, to allow makingFuseOptionKeyObjecta generic// footo jsdoc comments/** foo */so they will be included in intellisenseRelated issues
FuseOptionKeyObjecttype doesn't match the implementation #655Was this a regression?
No, the
weightproperty has never been defined as optional and thegetFnproperty was introduced in 6.6.0