Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added match index location for array key[tris] #183

Merged
merged 10 commits into from Aug 20, 2017
Merged

Added match index location for array key[tris] #183

merged 10 commits into from Aug 20, 2017

Conversation

Hypnosphi
Copy link
Contributor

@Hypnosphi Hypnosphi commented Aug 6, 2017

Same PR as #167 with some improvements:

  • index was renamed to arrayIndex to highlight difference with indices
  • arrayIndex is passed even if array has length 1, for consistency
  • matches items now have value field with original text value which makes dead simple to check if the match corresponds to particular field
  • minMatchCharLength doesn't work properly #164 fix respects the docs and excludes only matches, not results
  • tests added

@igor-dv
Copy link

igor-dv commented Aug 12, 2017

@krisk , will this PR be marged soon ?

@krisk
Copy link
Owner

krisk commented Aug 17, 2017

Could you address the failure? Thanks!

@Hypnosphi
Copy link
Contributor Author

Looks like I just had to run build before commiting. Maybe it's worth to run it before tests on CI

@krisk krisk merged commit 85df1cf into krisk:master Aug 20, 2017
@krisk
Copy link
Owner

krisk commented Aug 20, 2017

Great 👍I’ll publish a new version with these (and other) changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants