Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS version *Open for review #55

Closed
wants to merge 9 commits into from
Closed

SASS version *Open for review #55

wants to merge 9 commits into from

Conversation

kristoferjoseph
Copy link
Owner

Opening this pr for conversations.

@kristoferjoseph kristoferjoseph changed the title Initial pass at sass version. Not working yet. SASS version *Open for review Mar 12, 2015
@GianlucaGuarini
Copy link

I am unable to compile. It seems libsass has several problems with selectors strings interpolation like this

@kristoferjoseph
Copy link
Owner Author

Yes, this is one of the main reasons I didn't want to support SASS in the first place. The libsass vs sass and all of possible issues that can crop up from downstream dependencies being out of sync ( gulp-sass etc. ) is kind of a nightmare.

At the time of authoring this compilation worked. @GianlucaGuarini I've added a shrinkwrap file to help with this, can you try using that and let me know if that fixes your issue?

@GianlucaGuarini
Copy link

It does not solve the problem because I am compiling using just sass via command line including flexboxgrid.scss as vendor dependency

@kristoferjoseph
Copy link
Owner Author

That is not a supported way to compile this project. With that said, if you can figure it out a PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants