Migrate over to new terraform SDK #16
Merged
+144
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masutaka Let me know when the PR is rebased and I'll have a look. Great work my friend! |
masutaka
force-pushed
the
terraform-plugin-sdk
branch
2 times, most recently
from
3692c05
to
80ce7e9
Compare
|
@kristofferahl Please review! |
The reason is the below: $ go mod vendor $ tf-sdk-migrator check Checking Go runtime version ... Go version 1.13.1: OK. Checking whether provider uses Go modules... Go modules in use: OK. Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated... Checking version of github.com/hashicorp/terraform used in provider... Terraform version does not satisfy constraint >=0.12.7. Found Terraform version: 0.12.2 Checking whether provider uses deprecated SDK packages or identifiers... No imports of deprecated SDK packages or identifiers: OK. Some constraints not satisfied. Please resolve these before migrating to the new SDK. $ go get github.com/hashicorp/terraform $ tf-sdk-migrator check Checking Go runtime version ... Go version 1.13.1: OK. Checking whether provider uses Go modules... Go modules in use: OK. Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated... Checking version of github.com/hashicorp/terraform used in provider... Terraform version 0.12.10: OK. Checking whether provider uses deprecated SDK packages or identifiers... No imports of deprecated SDK packages or identifiers: OK. All constraints satisfied. Provider can be migrated to the new SDK.
Checking Go runtime version ... Go version 1.13.1: OK. Checking whether provider uses Go modules... Go modules in use: OK. Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated... Checking version of github.com/hashicorp/terraform used in provider... Terraform version 0.12.10: OK. Checking whether provider uses deprecated SDK packages or identifiers... No imports of deprecated SDK packages or identifiers: OK. All constraints satisfied. Provider can be migrated to the new SDK. Rewriting provider go.mod file... Rewriting SDK package imports... Running `go mod tidy`... Success! Provider is migrated to github.com/hashicorp/terraform-plugin-sdk v1.1.0. It looks like this provider vendors dependencies. Don't forget to run `go mod vendor`. Make sure to review all changes and run all tests.
masutaka
force-pushed
the
terraform-plugin-sdk
branch
from
80ce7e9
to
ed6f93e
Compare
|
Please review it again. FYI: Many of the changes in go.sum are due to |
kristofferahl
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Looks great @masutaka! Had to make some changes to the build in order to get it working (docker image layer caching is a paid feature it seems). Merging the PR!
|
@masutaka Should we create a new release? |
|
Yes, it's good. |
|
Created a new release with the tag v1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://www.terraform.io/docs/extend/plugin-sdk.html.
It seemed to be a seamless upgrade.