Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate over to new terraform SDK #16

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Migrate over to new terraform SDK #16

merged 4 commits into from
Oct 10, 2019
+144 −261

Commits on Oct 10, 2019

  1. $ go get github.com/hashicorp/terraform 

    The reason is the below:

$ go mod vendor

$ tf-sdk-migrator check
Checking Go runtime version ...
Go version 1.13.1: OK.
Checking whether provider uses Go modules...
Go modules in use: OK.
Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated...
Checking version of github.com/hashicorp/terraform used in provider...
Terraform version does not satisfy constraint >=0.12.7. Found Terraform version: 0.12.2
Checking whether provider uses deprecated SDK packages or identifiers...
No imports of deprecated SDK packages or identifiers: OK.

Some constraints not satisfied. Please resolve these before migrating to the new SDK.

$ go get github.com/hashicorp/terraform

$ tf-sdk-migrator check
Checking Go runtime version ...
Go version 1.13.1: OK.
Checking whether provider uses Go modules...
Go modules in use: OK.
Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated...
Checking version of github.com/hashicorp/terraform used in provider...
Terraform version 0.12.10: OK.
Checking whether provider uses deprecated SDK packages or identifiers...
No imports of deprecated SDK packages or identifiers: OK.

All constraints satisfied. Provider can be migrated to the new SDK.
    @masutaka
    masutaka committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    7c0f2ae View commit details
    Browse the repository at this point in the history

  2. $ tf-sdk-migrator migrate 

    Checking Go runtime version ...
Go version 1.13.1: OK.
Checking whether provider uses Go modules...
Go modules in use: OK.
Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated...
Checking version of github.com/hashicorp/terraform used in provider...
Terraform version 0.12.10: OK.
Checking whether provider uses deprecated SDK packages or identifiers...
No imports of deprecated SDK packages or identifiers: OK.

All constraints satisfied. Provider can be migrated to the new SDK.

Rewriting provider go.mod file...
Rewriting SDK package imports...
Running `go mod tidy`...
Success! Provider is migrated to github.com/hashicorp/terraform-plugin-sdk v1.1.0.

It looks like this provider vendors dependencies. Don't forget to run `go mod vendor`.
Make sure to review all changes and run all tests.
    @masutaka
    masutaka committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    ed6f93e View commit details
    Browse the repository at this point in the history

  3. - Syntax highlighting for terraform in readme (trick to fool Circle C… 

    …I to build again).
    Kristoffer Ahl committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    791b59e View commit details
    Browse the repository at this point in the history

  4. - Disabling docker image layer cache as it fails the build.

    Kristoffer Ahl committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    ecee027 View commit details
    Browse the repository at this point in the history