Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process command escaping still broken on windows #155

Closed
ghost opened this issue Nov 16, 2011 · 3 comments
Closed

process command escaping still broken on windows #155

ghost opened this issue Nov 16, 2011 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 16, 2011

ProcessBuilder.php line 103 and 106 don't escape arguments for windows

@kriswallsmith
Copy link
Owner

Are you experiencing an issue because of this?

On Nov 16, 2011, at 2:20 PM, Stainslav Turza
reply@reply.github.com
wrote:

ProcessBuilder.php line 103 and 106 don't escape arguments for windows


Reply to this email directly or view it on GitHub:
#155

@ghost
Copy link
Author

ghost commented Nov 16, 2011

yes im correcting it every symfony stable update ...

from

"C:\Windows\SysWOW64\java.exe" "-jar" "D:\Web\uicompressor.jar" "--charset" "UTF-8" "-o" "G:\TEMP\ed9465f-min.js" ... >>> RuntimeException The filename, directory name or volume label is incorrect

to

C:\Windows\SysWOW64\java.exe -jar D:\Web\yuicompressor.jar --charset UTF-8 -o G:\TEMP\ed9465f-min.js ...

@ghost
Copy link
Author

ghost commented Dec 8, 2011

i bad assetic version in deps file ;/ .. master is ok

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant