Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't alter timeout for filter processes #250

Closed
rhunwicks opened this issue Jul 6, 2012 · 10 comments
Closed

Can't alter timeout for filter processes #250

rhunwicks opened this issue Jul 6, 2012 · 10 comments

Comments

@rhunwicks
Copy link

Using Symfony 2.1 Beta, when I do php app/console assetic:dump --env=prod --no-debug I get

[RuntimeException]      
The process timed out. 

This is because the filters (Google Closure in my case) build a process using Symfony\Component\Process\ProcessBuilder and then call $pb->getProcess() to get the actual process. Unless you call $pb->setTimeout() before calling $pb->getProcess() the process has the default timeout of 60 seconds. This isn't long enough to compile my JavaScript on the Amazon EC2 micro instance I'm using as a test server.

Ideally this would be configurable somehow, but failing that I think it should be longer.

@blaugueux
Copy link

+1

@moodytux
Copy link

I've also found this with the yui_css and yui_js on Amazon micros. I've submitted a pull request so hopefully this will be accepted.

#277
#278

@jeremymoore
Copy link

+1... I'm using an Amazon EC2 small instance am experiencing the same thing during an assetic:dump in a Capistrano deployment. I am using less, cssrewrite and yui_css compressor filters.

@jcart
Copy link

jcart commented Dec 18, 2012

+1

@kachkaev
Copy link

Same thing (using Symfony 2.2-dev). Fixing this would be very helpful. @kriswallsmith, thanks for starting working on this in the last few days, I'm sure that many developers will be very glad to see something like

assetic:
    timeout: 120

or

assetic:
    filters:
        closure:
            jar: %kernel.root_dir%/Resources/java/compiler.jar
            timeout: 120
        yui_css:
            jar: %kernel.root_dir%/Resources/java/yuicompressor.jar
            timeout: 120

in their config.yml files. I also can’t wait for this to become possible too!

@audriusbugas
Copy link

+1, same issues on compass filter

@rubas
Copy link

rubas commented Feb 23, 2013

👍 , same issue with compass and sprites generation

symfony/assetic-bundle#170

@kriswallsmith
Copy link
Owner

This has been fixed in AsseticBundle.

@kachkaev
Copy link

@kriswallsmith is it fixed for all filters including closure or just for compass?

@rubas
Copy link

rubas commented Feb 24, 2013

If the filter extends https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/BaseProcessFilter.php#L31 you can set the timeout for the process.

Closure is not ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants