New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds CacheBustingWorker #297
Conversation
case 'modification': | ||
hash_update($hash, $asset->getLastModified()); | ||
break; | ||
case 'content': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add class constants for the strategies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
If this gets accepted I'll add support for it in the AsseticBundle, maybe enable it by default. |
|
||
You can use the CacheBustingWorker to provide unique names. | ||
|
||
To strategies are provided: 'content' (content based), 'modification' (modification time based) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc is wrong here as they are now 1 and 2 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Alternative implementation for #190 and #143. Using @kriswallsmith code as a base.