Add ability to stop listening for changes #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes bindings outlive objects that depend on them. In those cases, we need the ability to remove
receive
callbacks associated with those objects.I updated
Binding.prototype.receive
to return a handle with aremove
method that can be called to remove the callback. This means that theget(property, callback)
shorthand is somewhat broken in thatget
cannot return both a binding and a handle for callback removal. Because of this, I removed this shorthand frombind.js
and the README. While I was in the README, I also corrected mention ofbinding.then
tobinding.receive
.What are your thoughts?
P.S. In getting to know dbind, the shorthand methods were a distraction from seeing the essential simplicity of the API. Perhaps it would be better if there was no shorthand for things like
binding.get(prop).put(value)
.