Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): unify token burn permissions with mint #178

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

kangsorang
Copy link
Contributor

Description

Unify the permission to burn tokens with the permission to mint.

Tokens will managed consistently through governance.

@kangsorang kangsorang requested a review from a team as a code owner August 25, 2023 09:27
@kangsorang kangsorang changed the title feat(contract): Unify token burn permissions with mint feat(contract): unify token burn permissions with mint Aug 25, 2023
@Pangssu
Copy link
Contributor

Pangssu commented Aug 25, 2023

Why don't you remain the standard burn(), and add safeBurn()?

@kangsorang
Copy link
Contributor Author

Why don't you remain the standard burn(), and add safeBurn()?

The idea was to not allow token holders to self-burn, but to manage tokens solely through governance.

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh
Copy link
Contributor

seolaoh commented Aug 25, 2023

Please limit the commit msg in 80 characters and change to feat(contracts) of PR title and commit msg.

@kangsorang kangsorang force-pushed the feat/unify-burn-mint-permission branch from 113ed9c to dce47e6 Compare August 25, 2023 10:00
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seolaoh seolaoh changed the title feat(contract): unify token burn permissions with mint feat(contracts): unify token burn permissions with mint Aug 25, 2023
Unify the permission to burn tokens with the permission to mint.
Tokens will managed consistently through governance.
@kangsorang kangsorang force-pushed the feat/unify-burn-mint-permission branch from dce47e6 to 14c7ea6 Compare August 25, 2023 10:10
@seolaoh seolaoh merged commit 7a21452 into dev Aug 25, 2023
2 checks passed
@seolaoh seolaoh deleted the feat/unify-burn-mint-permission branch August 25, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants