Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): apply op-node v1.0.3 to kroma #34

Merged
merged 3 commits into from
Apr 27, 2023
Merged

feat(node): apply op-node v1.0.3 to kroma #34

merged 3 commits into from
Apr 27, 2023

Conversation

0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented Apr 20, 2023 •
edited
Loading

Changelog

v1.0.3

v1.0.2

v1.0.1

Other commits

  • delay creating blocks when safe lag exceeds limit (685c40f)
  • generalize and improve alt-sync (cdac097)
  • handle duplicates in payloads-queue by hash, not by number (7c60017)
  • harden eth RPC block/header retrieval by ensuring results (93f4e4b)
  • p2p alt-sync review fixes (62dffcc)
  • set up a blocked map sidecar for better performance (d37d91c)

@0xHansLee 0xHansLee force-pushed the apply-optimism-v1.0.3-node branch 3 times, most recently from c93cac7 to c1fd41f Compare April 20, 2023 08:06
@0xHansLee 0xHansLee self-assigned this Apr 20, 2023
@0xHansLee 0xHansLee force-pushed the apply-optimism-v1.0.3-node branch 2 times, most recently from 1ec6f1a to 38aedc8 Compare April 20, 2023 09:40
@0xHansLee
Copy link
Contributor Author

Sorry for naming this branch not conforming our rule 🥲

@0xHansLee 0xHansLee changed the title [WIP] feat: apply optimism v1.0.3 node to kanvas [WIP] feat: apply optimism v1.0.3 to kroma Apr 21, 2023
@0xHansLee 0xHansLee changed the base branch from dev to feat/apply-optimism-v1.0.3 April 24, 2023 07:37
@0xHansLee 0xHansLee changed the title [WIP] feat: apply optimism v1.0.3 to kroma [WIP] feat: apply op-node v1.0.3 to kroma Apr 24, 2023
@0xHansLee
Copy link
Contributor Author

@seolaoh
As we discussed, feat/apply-optimism-v1.0.3 will be the main branch to apply optimism v1.0.3.
After all changes are reflected (such as batcher, validator, etc.), a new PR to merge into the dev branch will be opened.

@0xHansLee 0xHansLee closed this Apr 24, 2023
@0xHansLee 0xHansLee deleted the apply-optimism-v1.0.3-node branch April 24, 2023 07:44
@0xHansLee 0xHansLee restored the apply-optimism-v1.0.3-node branch April 24, 2023 07:49
@0xHansLee 0xHansLee reopened this Apr 24, 2023
@0xHansLee 0xHansLee requested a review from seolaoh April 24, 2023 07:50
@0xHansLee 0xHansLee changed the title [WIP] feat: apply op-node v1.0.3 to kroma feat: apply op-node v1.0.3 to kroma Apr 24, 2023
@0xHansLee 0xHansLee marked this pull request as ready for review April 24, 2023 07:51
@0xHansLee 0xHansLee requested review from a team as code owners April 24, 2023 07:51
chokobole
chokobole reviewed Apr 24, 2023
View reviewed changes
components/node/client/rpc.go Outdated Show resolved Hide resolved
components/node/cmd/batch_decoder/README.md Outdated Show resolved Hide resolved
components/node/flags/flags.go Show resolved Hide resolved
components/node/flags/p2p_flags.go Show resolved Hide resolved
components/node/p2p/host_test.go Outdated Show resolved Hide resolved
components/node/p2p/sync.go Outdated Show resolved Hide resolved
specs/rollup-node-p2p.md Outdated Show resolved Hide resolved
specs/rollup-node-p2p.md Outdated Show resolved Hide resolved
components/node/p2p/sync.go Show resolved Hide resolved
components/node/p2p/sync_test.go Outdated Show resolved Hide resolved
@0xHansLee 0xHansLee changed the title feat: apply op-node v1.0.3 to kroma feat(node): apply op-node v1.0.3 to kroma Apr 25, 2023
chokobole
chokobole reviewed Apr 25, 2023
View reviewed changes
components/node/rollup/driver/state.go Outdated
// checkForGapInUnsafeQueue checks if there is a gap in the unsafe queue and attempts to retrieve the missing payloads from an alt-sync method.
// WARNING: This is only an outgoing signal, the blocks are not guaranteed to be retrieved.
// Results are received through OnUnsafeL2Payload.
func (s *Driver) checkForGapInUnsafeQueue(ctx context.Context) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i made a mistake. What I meant was like other examples, (d* Driver) looks better than (s *Driver)

components/node/rollup/derive/system_config_test.go Outdated Show resolved Hide resolved
0xHansLee and others added 3 commits April 26, 2023 09:44
@0xHansLee
feat(node): apply op-node v1.0.3 to kroma
af542d0 
- fix peer scoring and related metrics (218828d)
- delay creating blocks when safe lag exceeds limit (685c40f)
- generalize and improve alt-sync (cdac097)
- handle duplicates in payloads-queue by hash, not by number (7c60017)
- implement RPC poll interval and rate-limit options and provide L1 RPC CLI options (d8764ed)
- req-resp p2p sync with new feature-flag (0d7859b)
@0xHansLee
chore: update FORK.md
6113892
@0xHansLee
chore: rename receiver
9ee7e0b
chokobole
chokobole approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit e0d1284 into feat/apply-optimism-v1.0.3 Apr 27, 2023
@0xHansLee 0xHansLee deleted the apply-optimism-v1.0.3-node branch April 27, 2023 01:19
@seolaoh seolaoh mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@seolaoh seolaoh Awaiting requested review from seolaoh

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xHansLee @chokobole