-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Add channel_input_bytes metric #5385
Conversation
Adds gauge metric for the amount of compressed bytes read from the channel just prior to batch decoding.
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With gauge + set metric functionality we'll miss data, and get inaccurate rate metrics
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Adds gauge metric for the amount of compressed bytes read from the channel just prior to batch decoding.
This is useful when paired with the batcher
output_bytes
to get a better sense on the data rates throughout the system.