Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Add channel_input_bytes metric #5385

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Apr 7, 2023

Adds gauge metric for the amount of compressed bytes read from the channel just prior to batch decoding.

This is useful when paired with the batcher output_bytes to get a better sense on the data rates throughout the system.

Adds gauge metric for the amount of compressed bytes read from the
channel just prior to batch decoding.
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

⚠️ No Changeset found

Latest commit: 06bea64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 06bea64
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64303b137ee8c3000801dc58

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With gauge + set metric functionality we'll miss data, and get inaccurate rate metrics

op-node/metrics/metrics.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit cbb0bb5 into develop Apr 7, 2023
@OptimismBot OptimismBot deleted the inphi/chan-in-metrics branch April 7, 2023 16:03
@mergify mergify bot removed the on-merge-train label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants