Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply the rest of Optimism v1.0.3 to Kroma #49

Merged
merged 14 commits into from
May 15, 2023

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented May 10, 2023

Description

Remarkable Changes

op-e2e

op-chain-ops

packages/common-ts

packages/contracts

docs

@seolaoh seolaoh requested a review from a team as a code owner May 10, 2023 11:31
@seolaoh seolaoh self-assigned this May 10, 2023
@chokobole
Copy link
Contributor

Please update bindings!

> cd bindings
> make more
> git diff
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   bindings/kromaportal_more.go
        modified:   bindings/l1block_more.go
        modified:   bindings/systemconfig_more.go

packages/common-ts/.depcheckrc Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/KromaPortal.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/echidna/FuzzKromaPortal.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/test/CommonTest.t.sol Outdated Show resolved Hide resolved
packages/contracts/deploy/106-ValidatorRewardVault.ts Outdated Show resolved Hide resolved
packages/contracts/deploy/107-ProtocolVault.ts Outdated Show resolved Hide resolved
packages/contracts/deploy/108-ProposerRewardVault.ts Outdated Show resolved Hide resolved
@chokobole
Copy link
Contributor

Please update bindings!

> cd bindings
> make more
> git diff
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   bindings/kromaportal_more.go
        modified:   bindings/l1block_more.go
        modified:   bindings/systemconfig_more.go

When I did like below, it gives outputs like above.

# at packages/contracts
> npx hardhat compile
# at bindings
> make more

Strangely, if I tried after removing artifacts, it gives the same output as this PR.

@seolaoh
Copy link
Contributor Author

seolaoh commented May 12, 2023

Please update bindings!

> cd bindings
> make more
> git diff
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   bindings/kromaportal_more.go
        modified:   bindings/l1block_more.go
        modified:   bindings/systemconfig_more.go

When I did like below, it gives outputs like above.

# at packages/contracts
> npx hardhat compile
# at bindings
> make more

Strangely, if I tried after removing artifacts, it gives the same output as this PR.

I think you should delete your ./packages/contracts/cache folder, that is created before by npx hardhat compile.
So you should run like below to regenerate bindings.

# at ./packages/contracts
> yarn clean && npx hardhat compile
# at ./bindings
> make more

or just simply

# at ./
> make bindings

@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-etc branch 2 times, most recently from 6e9e3a7 to 3ea0b8d Compare May 12, 2023 10:12
@seolaoh
Copy link
Contributor Author

seolaoh commented May 12, 2023

@chokobole I reflected your comments and added a few new commits.

@seolaoh seolaoh requested a review from chokobole May 12, 2023 10:15
specs/withdrawals.md Outdated Show resolved Hide resolved
@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-etc branch from 3ea0b8d to b94e5ef Compare May 15, 2023 01:58
@seolaoh seolaoh requested a review from chokobole May 15, 2023 01:59
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged this pull request into feat/apply-optimism-v1.0.3 May 15, 2023
@chokobole chokobole deleted the feat/apply-optimism-v1.0.3-etc branch May 15, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants