Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txmgr: Simplify API #5306

Merged
merged 2 commits into from
Apr 3, 2023
Merged

txmgr: Simplify API #5306

merged 2 commits into from
Apr 3, 2023

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Mar 30, 2023

Description

This simplifies some of the transaction manager APIs.

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

⚠️ No Changeset found

Latest commit: 0395c9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere marked this pull request as ready for review March 30, 2023 23:10
@trianglesphere trianglesphere requested a review from a team as a code owner March 30, 2023 23:10
@trianglesphere trianglesphere requested review from tynes and sebastianst and removed request for a team March 30, 2023 23:10
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #5306 (0395c9f) into develop (37dddde) will decrease coverage by 4.02%.
The diff coverage is 56.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5306      +/-   ##
===========================================
- Coverage    39.31%   35.29%   -4.02%     
===========================================
  Files          389      225     -164     
  Lines        25056    20052    -5004     
  Branches       838        0     -838     
===========================================
- Hits          9851     7078    -2773     
+ Misses       14469    12295    -2174     
+ Partials       736      679      -57     
Flag Coverage Δ
bedrock-go-tests 35.29% <56.52%> (-0.29%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/batcher/driver.go 0.00% <0.00%> (ø)
op-service/txmgr/cli.go 48.61% <50.00%> (+5.55%) ⬆️
op-service/txmgr/txmgr.go 76.22% <71.42%> (-2.88%) ⬇️

... and 169 files with indirect coverage changes

@trianglesphere trianglesphere requested a review from a team as a code owner March 31, 2023 15:32
@trianglesphere trianglesphere requested review from mslipper and removed request for a team March 31, 2023 15:32
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Mar 31, 2023
Base automatically changed from jg/tx_lifecycle_mgmt to develop March 31, 2023 18:46
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 0395c9f
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642b2bea1708390008d162fc

@mergify mergify bot removed the conflict label Mar 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit b9a8281 into develop Apr 3, 2023
@mergify mergify bot deleted the jg/cleanup_txmgr_apis branch April 3, 2023 19:59
@mergify mergify bot removed the on-merge-train label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants