Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: allow string conversions to accept malformed input #388

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refac: allow string conversions to accept malformed input #388

merged 2 commits into from
Apr 12, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR allows XXX::FromDestring() and XXX::FromHexString() to accept malformed input.

Closes: #386

@chokobole chokobole force-pushed the refac/allow-string-conversions-to-accept-malformed-input branch 2 times, most recently from 0291e8d to 78142b8 Compare April 11, 2024 21:42
TomTaehoonKim
TomTaehoonKim approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else, LGTM

tachyon/py/math/finite_fields/prime_field.h Show resolved Hide resolved
Insun35
Insun35 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the refac/allow-string-conversions-to-accept-malformed-input branch from 78142b8 to debd9c6 Compare April 12, 2024 09:44
ashjeong
ashjeong approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chokobole chokobole merged commit 3b2dff9 into main Apr 12, 2024
3 checks passed
@chokobole chokobole deleted the refac/allow-string-conversions-to-accept-malformed-input branch April 12, 2024 15:44
chokobole added a commit that referenced this pull request Apr 16, 2024
@chokobole
fix(math): add missing changes from #388
bf163fc
@chokobole chokobole mentioned this pull request Apr 16, 2024
Merged
chokobole added a commit that referenced this pull request Apr 17, 2024
@chokobole
fix(math): add missing changes from #388
8c28481
chokobole added a commit that referenced this pull request Apr 18, 2024
@chokobole
fix(math): add missing changes from #388
504a8e3
chokobole added a commit that referenced this pull request Apr 18, 2024
@chokobole
Merge pull request #392 from kroma-network/fix/fix-compile-error-with…
8f3c1ad 
…-cuda

fix(math): add missing changes from #388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@Insun35 Insun35 Insun35 approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow From(Dec|Hex)String to accept malformed input string
5 participants
@chokobole @dongchangYoo @Insun35 @TomTaehoonKim @ashjeong